Add opentracing example to set span #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotak
force-pushed
the
example-set-span
branch
3 times, most recently
from
062545f
to
e7a21ac
Compare
Signed-off-by: Joel Takvorian <joel.takvorian@qaraywa.net>
jotak
force-pushed
the
example-set-span
branch
from
e7a21ac
to
cd49f41
Compare
|
can you rebase @jotak ? |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information will help to understand what vert.x expects, in particular ACTIVE_SPAN has to be set in order to have spans injected in client requests.
PS: I haven't used the Zipkin implementation already, but I can amend this PR if someone tells me the equivalent thing to do.